Skip to content

fix: hide preview action in split mode#20264

Open
sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
sanjaysargam:preview
Open

fix: hide preview action in split mode#20264
sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
sanjaysargam:preview

Conversation

@sanjaysargam
Copy link
Member

Purpose / Description

Preview action was appearing twice in the toolbar menu.This happened because the menu items were only removed when both conditions were true

Fixes

Approach

Switched to || so menu items are removed as soon as either condition met

How Has This Been Tested?

Chromebook

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

preview action was appearing twice in the toolbar menu.This happened because the menu items were only removed when both conditions were true
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 30, 2026
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jan 30, 2026
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this should be blocked on #20208

See the commit message on e606599 regarding duplicated IDs

Once that PR is merged, we want to go back to the the drawing board here: previewing the edited changes on a card is a useful feature which this PR removes for users in tablet mode. [if the dev setting is toggled]

After the correct course of action is determined, needs a couple more tests regarding what the menus look like when there's no selected rows.

EDIT: The correct course of action can be to merge, and move the discussion point to #20206


Wait... this doesn't fix the linked issue

@github-actions
Copy link
Contributor

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Productionize 'Side-by-side browser and editor'

4 participants