fix: hide preview action in split mode#20264
fix: hide preview action in split mode#20264sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
Conversation
preview action was appearing twice in the toolbar menu.This happened because the menu items were only removed when both conditions were true
There was a problem hiding this comment.
- this should be blocked on #20208
See the commit message on e606599 regarding duplicated IDs
Once that PR is merged, we want to go back to the the drawing board here: previewing the edited changes on a card is a useful feature which this PR removes for users in tablet mode. [if the dev setting is toggled]
After the correct course of action is determined, needs a couple more tests regarding what the menus look like when there's no selected rows.
EDIT: The correct course of action can be to merge, and move the discussion point to #20206
Wait... this doesn't fix the linked issue
|
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
Purpose / Description
Preview action was appearing twice in the toolbar menu.This happened because the menu items were only removed when both conditions were true
Fixes
Approach
Switched to
||so menu items are removed as soon as either condition metHow Has This Been Tested?
Chromebook
Checklist
Please, go through these checks before submitting the PR.