Skip to content

Labeling refactor/followups#3456

Open
josephperrott wants to merge 6 commits intoangular:mainfrom
josephperrott:issue-labeling-follow-ups
Open

Labeling refactor/followups#3456
josephperrott wants to merge 6 commits intoangular:mainfrom
josephperrott:issue-labeling-follow-ups

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Feb 27, 2026

No description provided.

@josephperrott josephperrott changed the title issue labeling follow ups Labeling refactor/followups Feb 27, 2026
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this.pullRequestFilePaths.length > 0 &&
micromatch(this.pullRequestFilePaths, paths as string | string[]).length > 0
) {
console.log(label);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a few console logs here.

…base class

Extracts the common logic used by IssueLabeling and PullRequestLabeling into a
shared Labeling base class. This simplifies code duplication and unifies how
labels are added, removed, and authentication is handled with Octokit.
@josephperrott josephperrott force-pushed the issue-labeling-follow-ups branch from 242742d to 7d50193 Compare February 27, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants