fix(ng-dev): replace node_version_from_nvmrc with concrete version in Bazel module
#3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Bazel module This change modifies the `sync-module-bazel` script to replace `node_version_from_nvmrc` with a concrete `node_version` derived from `.nvmrc` when processing the `node.toolchain` arguments. This workaround addresses a bug with `node_version_from_nvmrc` when used alongside `node_repositories` in `rules_nodejs` (specifically < 6.6.3), ensuring that the toolchain is correctly configured with the specific Node.js version and its corresponding repositories.
devversion
approved these changes
Jan 12, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
sync-module-bazelscript to replacenode_version_from_nvmrcwith a concretenode_versionderived from.nvmrcwhen processing thenode.toolchainarguments.This workaround addresses a bug with
node_version_from_nvmrcwhen used alongsidenode_repositoriesinrules_nodejs(specifically < 6.6.3), ensuring that the toolchain is correctly configured with the specific Node.js version and its corresponding repositories.