fix(aria/menu): remove aria-label binding from menu item value#32894
Closed
mhoechtl wants to merge 1 commit intoangular:mainfrom
Closed
fix(aria/menu): remove aria-label binding from menu item value#32894mhoechtl wants to merge 1 commit intoangular:mainfrom
mhoechtl wants to merge 1 commit intoangular:mainfrom
Conversation
Removes the `[attr.aria-label]="value()"` host binding from `ngMenuItem`. Binding `value` to `aria-label` causes several issues: 1. Couples application logic/data (value) with UI accessibility state. 2. Creates i18n issues if the value is a non-localized identifier. 3. Overwrites explicitly provided `aria-label` attributes on the host element. 4. Overrides the native accessible name derivation (textContent) of the menuitem. Fixes angular#32893
ok7sai
approved these changes
Mar 5, 2026
Member
ok7sai
left a comment
ok7sai
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The label input overwrites the aria-label is certainly an unwanted behavior.
ok7sai
added
target: minor
Member
|
I ended up taking this over in #33202 since we had some internal clients asking for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
[attr.aria-label]="value()"host binding fromngMenuItem.Binding
valuetoaria-labelcauses several issues:aria-labelattributes on the host element.Fixes #32893