Skip to content

refactor(multiple): strongly type SimpleChanges #32871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisbeto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(multiple): strongly type SimpleChanges #32871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/cdk/a11y/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class CdkTrapFocus implements OnDestroy, AfterContentInit, OnChanges, DoC
// (undocumented)
ngDoCheck(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down
6 changes: 2 additions & 4 deletions goldens/cdk/accordion/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ export class CdkAccordion implements OnDestroy, OnChanges {
// (undocumented)
static ngAcceptInputType_multi: unknown;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
openAll(): void;
readonly _openCloseAllActions: Subject<boolean>;
readonly _stateChanges: Subject<{
[propName: string]: i0.SimpleChange<any>;
}>;
readonly _stateChanges: Subject<SimpleChanges<this>>;
// (undocumented)
static ɵdir: i0.ɵɵDirectiveDeclaration<CdkAccordion, "cdk-accordion, [cdkAccordion]", ["cdkAccordion"], { "multi": { "alias": "multi"; "required": false; }; }, {}, never, never, true, never>;
// (undocumented)
Expand Down
2 changes: 1 addition & 1 deletion goldens/cdk/drag-drop/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnChanges, OnDestroy {
// (undocumented)
ngAfterViewInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
previewClass: string | string[];
Expand Down
2 changes: 1 addition & 1 deletion goldens/cdk/menu/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnChanges, OnD
getMenu(): Menu | undefined;
_handleClick(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
open(): void;
Expand Down
2 changes: 1 addition & 1 deletion goldens/cdk/overlay/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
// (undocumented)
static ngAcceptInputType_push: unknown;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
get offsetX(): number;
Expand Down
6 changes: 3 additions & 3 deletions goldens/cdk/table/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export abstract class BaseRowDef implements OnChanges {
extractCellTemplate(column: CdkColumnDef): TemplateRef<any>;
getColumnsDiff(): IterableChanges<any> | null;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
template: TemplateRef<any>;
// (undocumented)
Expand Down Expand Up @@ -187,7 +187,7 @@ export class CdkFooterRowDef extends BaseRowDef implements CanStick, OnChanges {
// (undocumented)
static ngAcceptInputType_sticky: unknown;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
resetStickyChanged(): void;
get sticky(): boolean;
set sticky(value: boolean);
Expand Down Expand Up @@ -233,7 +233,7 @@ export class CdkHeaderRowDef extends BaseRowDef implements CanStick, OnChanges {
// (undocumented)
static ngAcceptInputType_sticky: unknown;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
resetStickyChanged(): void;
get sticky(): boolean;
set sticky(value: boolean);
Expand Down
14 changes: 7 additions & 7 deletions goldens/google-maps/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export class DeprecatedMapMarkerClusterer implements OnInit, AfterContentInit, O
// (undocumented)
ngAfterContentInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -271,7 +271,7 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
readonly maptypeidChanged: Observable<void>;
get mapTypes(): google.maps.MapTypeRegistry;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -328,7 +328,7 @@ export class MapAdvancedMarker implements OnInit, OnChanges, OnDestroy, MapAncho
readonly mapRightclick: Observable<MouseEvent>;
readonly markerInitialized: EventEmitter<google.maps.marker.AdvancedMarkerElement>;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -457,7 +457,7 @@ export class MapDirectionsRenderer implements OnInit, OnChanges, OnDestroy {
getPanel(): Node | null;
getRouteIndex(): number;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -546,7 +546,7 @@ export class MapHeatmapLayer implements OnInit, OnChanges, OnDestroy {
heatmap?: google.maps.visualization.HeatmapLayer;
readonly heatmapInitialized: EventEmitter<google.maps.visualization.HeatmapLayer>;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -654,7 +654,7 @@ export class MapMarker implements OnInit, OnChanges, OnDestroy, MapAnchorPoint,
marker?: google.maps.Marker;
readonly markerInitialized: EventEmitter<google.maps.Marker>;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -686,7 +686,7 @@ export class MapMarkerClusterer implements OnInit, OnChanges, OnDestroy {
// (undocumented)
_markers: QueryList<MarkerDirective>;
// (undocumented)
ngOnChanges(changes: SimpleChanges): Promise<void>;
ngOnChanges(changes: SimpleChanges<this>): Promise<void>;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/autocomplete/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, AfterViewIn
// (undocumented)
ngAfterViewInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
_onChange: (value: any) => void;
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/checkbox/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class MatCheckbox implements AfterViewInit, OnChanges, ControlValueAccess
// (undocumented)
ngAfterViewInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
_onBlur(): void;
// (undocumented)
Expand Down
10 changes: 5 additions & 5 deletions goldens/material/datepicker/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class MatCalendar<D> implements AfterContentInit, AfterViewChecked, OnDes
// (undocumented)
ngAfterViewChecked(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
get selected(): DateRange<D> | D | null;
Expand Down Expand Up @@ -200,7 +200,7 @@ export class MatCalendarBody<D = any> implements OnChanges, OnDestroy, AfterView
// (undocumented)
ngAfterViewChecked(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
numCols: number;
Expand Down Expand Up @@ -504,7 +504,7 @@ export class MatDatepickerToggle<D> implements AfterContentInit, OnChanges, OnDe
// (undocumented)
ngAfterContentInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down Expand Up @@ -569,7 +569,7 @@ export class MatDateRangeInput<D> implements MatFormFieldControl<DateRange<D>>,
ngAfterContentInit(): void;
ngControl: NgControl | null;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
onContainerClick(): void;
Expand Down Expand Up @@ -693,7 +693,7 @@ export class MatMonthView<D> implements AfterContentInit, OnChanges, OnDestroy {
// (undocumented)
ngAfterContentInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
_previewChanged({ event, value: cell }: MatCalendarUserEvent<MatCalendarCell<D> | null>): void;
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/dialog/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export class MatDialogClose implements OnInit, OnChanges {
// (undocumented)
_matDialogClose: any;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnInit(): void;
// (undocumented)
Expand Down
30 changes: 28 additions & 2 deletions goldens/material/expansion/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,41 @@ export class MatExpansionPanel extends CdkAccordionItem implements AfterContentI
get hideToggle(): boolean;
set hideToggle(value: boolean);
readonly _inputChanges: Subject<{
[propName: string]: i0.SimpleChange<any>;
hideToggle?: i0.SimpleChange<boolean> | undefined;
togglePosition?: i0.SimpleChange<MatAccordionTogglePosition> | undefined;
readonly afterExpand?: i0.SimpleChange<EventEmitter<void>> | undefined;
readonly afterCollapse?: i0.SimpleChange<EventEmitter<void>> | undefined;
readonly _inputChanges?: i0.SimpleChange<Subject</*elided*/ any>> | undefined;
accordion?: i0.SimpleChange<MatAccordionBase> | undefined;
_lazyContent?: i0.SimpleChange<MatExpansionPanelContent> | undefined;
_body?: i0.SimpleChange<ElementRef<HTMLElement>> | undefined;
_portal?: i0.SimpleChange<TemplatePortal<any>> | undefined;
_headerId?: i0.SimpleChange<string> | undefined;
_hasSpacing?: i0.SimpleChange<() => boolean> | undefined;
_getExpandedState?: i0.SimpleChange<() => MatExpansionPanelState> | undefined;
toggle?: i0.SimpleChange<() => void> | undefined;
close?: i0.SimpleChange<() => void> | undefined;
open?: i0.SimpleChange<() => void> | undefined;
ngAfterContentInit?: i0.SimpleChange<() => void> | undefined;
ngOnChanges?: i0.SimpleChange<(changes: /*elided*/ any) => void> | undefined;
ngOnDestroy?: i0.SimpleChange<() => void> | undefined;
_containsFocus?: i0.SimpleChange<() => boolean> | undefined;
readonly closed?: i0.SimpleChange<EventEmitter<void>> | undefined;
readonly opened?: i0.SimpleChange<EventEmitter<void>> | undefined;
readonly destroyed?: i0.SimpleChange<EventEmitter<void>> | undefined;
readonly expandedChange?: i0.SimpleChange<EventEmitter<boolean>> | undefined;
readonly id?: i0.SimpleChange<string> | undefined;
expanded?: i0.SimpleChange<boolean> | undefined;
disabled?: i0.SimpleChange<boolean> | undefined;
ngOnInit?: i0.SimpleChange<() => void> | undefined;
}>;
_lazyContent: MatExpansionPanelContent;
// (undocumented)
static ngAcceptInputType_hideToggle: unknown;
// (undocumented)
ngAfterContentInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
open(): void;
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/list/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export class MatSelectionList extends MatListBase implements SelectionList, Cont
// (undocumented)
ngAfterViewInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
_onTouched: () => void;
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/select/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ export class MatSelect implements AfterContentInit, OnChanges, OnDestroy, OnInit
// (undocumented)
ngDoCheck(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/slide-toggle/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class MatSlideToggle implements OnDestroy, AfterContentInit, OnChanges, C
// (undocumented)
ngAfterContentInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
_noopAnimations: boolean;
Expand Down
2 changes: 1 addition & 1 deletion goldens/material/tabs/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class MatTab implements OnInit, OnChanges, OnDestroy {
// (undocumented)
static ngAcceptInputType_disabled: unknown;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
// (undocumented)
Expand Down
2 changes: 1 addition & 1 deletion goldens/youtube-player/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class YouTubePlayer implements AfterViewInit, OnChanges, OnDestroy {
// (undocumented)
ngAfterViewInit(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
ngOnChanges(changes: SimpleChanges<this>): void;
// (undocumented)
ngOnDestroy(): void;
pauseVideo(): void;
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/a11y/focus-trap/focus-trap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ export class CdkTrapFocus implements OnDestroy, AfterContentInit, OnChanges, DoC
}
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
const autoCaptureChange = changes['autoCapture'];

if (
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/accordion/accordion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const CDK_ACCORDION = new InjectionToken<CdkAccordion>('CdkAccordion');
})
export class CdkAccordion implements OnDestroy, OnChanges {
/** Emits when the state of the accordion changes */
readonly _stateChanges = new Subject<SimpleChanges>();
readonly _stateChanges = new Subject<SimpleChanges<this>>();

/** Stream that emits true/false when openAll/closeAll is triggered. */
readonly _openCloseAllActions: Subject<boolean> = new Subject<boolean>();
Expand All @@ -59,7 +59,7 @@ export class CdkAccordion implements OnDestroy, OnChanges {
this._openCloseAllActions.next(false);
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
this._stateChanges.next(changes);
}

Expand Down
2 changes: 1 addition & 1 deletion src/cdk/drag-drop/directives/drag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnChanges, OnDestroy {
);
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
const rootSelectorChange = changes['rootElementSelector'];
const positionChange = changes['freeDragPosition'];

Expand Down
2 changes: 1 addition & 1 deletion src/cdk/menu/menu-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnChanges, OnD
return this.childMenu;
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
if (changes['menuPosition'] && this.overlayRef) {
this.overlayRef.updatePositionStrategy(this._getOverlayPositionStrategy());
}
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/overlay/overlay-directives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
this._overlayRef?.dispose();
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
if (this._position) {
this._updatePositionStrategy(this._position);
this._overlayRef?.updateSize({
Expand Down
6 changes: 3 additions & 3 deletions src/cdk/table/row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export abstract class BaseRowDef implements OnChanges {
constructor(...args: unknown[]);
constructor() {}

ngOnChanges(changes: SimpleChanges): void {
ngOnChanges(changes: SimpleChanges<this>): void {
// Create a new columns differ if one does not yet exist. Initialize it based on initial value
// of the columns property or an empty array if none is provided.
if (!this._columnsDiffer) {
Expand Down Expand Up @@ -116,7 +116,7 @@ export class CdkHeaderRowDef extends BaseRowDef implements CanStick, OnChanges {

// Prerender fails to recognize that ngOnChanges in a part of this class through inheritance.
// Explicitly define it so that the method is called as part of the Angular lifecycle.
override ngOnChanges(changes: SimpleChanges): void {
override ngOnChanges(changes: SimpleChanges<this>): void {
super.ngOnChanges(changes);
}

Expand Down Expand Up @@ -167,7 +167,7 @@ export class CdkFooterRowDef extends BaseRowDef implements CanStick, OnChanges {

// Prerender fails to recognize that ngOnChanges in a part of this class through inheritance.
// Explicitly define it so that the method is called as part of the Angular lifecycle.
override ngOnChanges(changes: SimpleChanges): void {
override ngOnChanges(changes: SimpleChanges<this>): void {
super.ngOnChanges(changes);
}

Expand Down
2 changes: 1 addition & 1 deletion src/google-maps/deprecated-map-marker-clusterer/deprecated-map-marker-clusterer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export class DeprecatedMapMarkerClusterer
}
}

ngOnChanges(changes: SimpleChanges) {
ngOnChanges(changes: SimpleChanges<this>) {
const {
markerClusterer: clusterer,
ariaLabelFn,
Expand Down
Loading
Loading