feat(select): add css vars for divider spacing#32867
Open
moniuch wants to merge 2 commits intoangular:mainfrom
Open
feat(select): add css vars for divider spacing#32867moniuch wants to merge 2 commits intoangular:mainfrom
moniuch wants to merge 2 commits intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
moniuch
commented
Feb 26, 2026
Comment on lines
+14
to
+15
| select-divider-bottom-spacing: 0, | ||
| select-divider-top-spacing: 0 |
Author
There was a problem hiding this comment.
I wasn't really sure here. 0 is the m2 default for mat-menu, but tbh it defies the purpose.
moniuch
force-pushed
the
feat/mat-select-spacing-vars
branch
from
b5a8f01 to
b103f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first rodeo in this repo, so please bear with me! :) I might have slipped here or there.
My understanding is that css vars are parsed automatically into the Styling section of the docs. Please instruct me otherwise.
This PR adds CSS vars to support spacing of
mat-dividerwithinmat-select, in alignment with the existing support inmat-menu.Closes #31707.