build: update dependency webpack-dev-server to v6 - #33735
Merged
Conversation
alan-agius4
force-pushed
the
pr-takeover-33514
branch
2 times, most recently
from
August 3, 2026 10:22
2095c1b to
ac402d5
Compare
See associated pull request for more information. Closes angular#33514 as a pr takeover
alan-agius4
force-pushed
the
pr-takeover-33514
branch
from
August 3, 2026 10:25
ac402d5 to
df4a43b
Compare
alan-agius4
marked this pull request as ready for review
August 3, 2026 11:33
There was a problem hiding this comment.
Code Review
This pull request upgrades webpack-dev-server to version 6.0.0 and updates the type references from WebpackDevServer.Configuration to Configuration. However, the upgrade introduces a critical runtime compatibility issue: webpack-dev-server v6 removes the callback-based startCallback and stopCallback methods. The code must be updated to use the Promise-based start() and stop() methods to support both v5 and v6 peer dependencies and prevent runtime crashes.
clydin
approved these changes
Aug 3, 2026
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #33514 as a pr takeover