fix(@angular/ssr): improve header validation logic#32622
Open
alan-agius4 wants to merge 1 commit intoangular:21.2.xfrom
Open
fix(@angular/ssr): improve header validation logic#32622alan-agius4 wants to merge 1 commit intoangular:21.2.xfrom
alan-agius4 wants to merge 1 commit intoangular:21.2.xfrom
Conversation
alan-agius4
added
action: review
Updates the `validateRequest` function to correctly handle the `allowedHost=true` option.
alan-agius4
force-pushed
the
handle-validation-patch
branch
from
53f59db to
d78ace4
Compare
dgp1130
approved these changes
Feb 27, 2026
Collaborator
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Question: Is allowedHosts: true distinct from allowedHosts: ['*'], which could also be set via environment variable? Is there a reason to prefer this instead?
|
|
||
| // Disable host check if allowed hosts is true meaning allow all hosts. | ||
| const { allowedHosts } = server.config.server; | ||
| const disableAllowedHostsCheck = allowedHosts === true; |
Collaborator
There was a problem hiding this comment.
Consider framing this in the positive like:
const checkAllowedHosts = Array.isArray(allowedHosts);As positive conditionals can often be easier to reason about.
Collaborator
Author
|
‘allowedHosts: ['*']’ is not supported, and ‘allowedHost=true` is already an option supported by Vite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
validateRequestfunction to correctly handle theallowedHost=trueoption.