fix(@angular/cli): use project-local temporary directory in ng add #32255
+117
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manager abstraction This change introduces the ability to specify a base temporary directory when creating a `PackageManager` instance. This allows for creating temporary directories within the project structure (e.g., `node_modules/.tmp`), which enables package managers to correctly inherit project-specific configurations like `.npmrc` or `.yarnrc` during operations like `acquireTempPackage`.
The 'ng add' command now attempts to use '.angular/cache' or 'node_modules' as the base for temporary directories when acquiring packages. This ensures that the package manager can inherit project-specific configuration (like '.npmrc' or '.yarnrc') during the installation of temporary packages. The implementation uses a fallback strategy, checking for candidate directories and defaulting to the system's temporary directory if none are found.
…on in ng add This change enhances the error handling in the 'ng add' command's 'installPackageTask'. It now specifically catches 'PackageManagerError' exceptions and surfaces the standard output or standard error from the underlying package manager process. This provides users with more actionable information when a package installation fails.
clydin
force-pushed
the
package-managers/temp-package-dir
branch
8 times, most recently
from
29a6564 to
d89b476
Compare
…ackages in bun This change introduces a 'project-root' strategy for acquiring temporary packages, which is now enabled for Bun. Bun has difficulty discovering and using configuration files (like '.npmrc') when executed in an isolated temporary directory. With the 'project-root' strategy, 'bun add' is executed directly in the project's root directory using the '--no-save' flag. This ensures correct configuration inheritance and reliable package resolution. The cleanup for this strategy is currently a no-op to avoid potentially destructive deletions within the project's 'node_modules'.
clydin
force-pushed
the
package-managers/temp-package-dir
branch
from
d89b476 to
f1c95a4
Compare
When resolving package manifests from file, git, or remote URLs, the CLI relies on installing the package into an isolated temporary directory to identify the package's name. This change forces the 'acquireTempPackage' method to use the 'temporary-directory' strategy for these lookups, ensuring that the package identification logic remains correct even when the package manager (like Bun) defaults to a 'project-root' strategy.
This change updates the 'ng add' command to dynamically determine the base directory for temporary package manager operations by consulting the workspace configuration. If caching is enabled and the cache path is located within the workspace root, it is added to the list of candidate directories alongside 'node_modules'. This ensures that the package manager correctly inherits project settings even when the user has customized the location of the '.angular' directory, while maintaining the requirement that the directory must be within the project context for configuration inheritance to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'ng add' command now attempts to use '.angular/cache' or 'node_modules' as the base for temporary directories when acquiring packages. This ensures that the package manager can inherit project-specific configuration (like '.npmrc' or '.yarnrc') during the installation of temporary packages.