Tailored error message for custom host#32056
Merged
hybrist merged 5 commits intoangular:mainfrom Dec 10, 2025
Merged
Conversation
alan-agius4
requested changes
Dec 8, 2025
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
03337ee to
2a4f460
Compare
alan-agius4
requested changes
Dec 9, 2025
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/builders/dev-server/tests/options/allowed-hosts_spec.ts
Outdated
Show resolved
Hide resolved
…tailored message New Blocked request page for custom host Fix angular#32028
2a4f460 to
af24a02
Compare
…ngular-tailored message
…ngular-tailored message
alan-agius4
approved these changes
Dec 9, 2025
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks
(pushed a cleanup commit)
…ngular-tailored message
…ngular-tailored message
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom middleware for to present an Angular-tailored message
Fix #32028
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The error message thrown when the Angular app is served via a custom hostname is incorrect/misleading
Issue Number: #32028
What is the new behavior?
Add custom middleware for to present an Angular-tailored message when angular served by ngrok
Does this PR introduce a breaking change?