fix(@angular/build): correct Vitest coverage include handling for virtual files#31833
Merged
clydin merged 1 commit intoangular:mainfrom Nov 17, 2025
Merged
Conversation
…tual files Addresses an issue where user-defined `coverageInclude` patterns in Vitest could incorrectly exclude bundled virtual files during the pre-sourcemap coverage check, leading to incomplete or empty coverage reports. This change modifies the `generateCoverageOption` function to augment user-provided `coverageInclude` arrays with specific globs (`spec-*.js`, `chunk-*.js`) that match the internal bundled test entry points and code chunks. This ensures that all necessary files are considered during Vitest's initial coverage pass, while still respecting the user's original `include` patterns for the post-sourcemap remapping.
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 17, 2025
alan-agius4
added
action: merge
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue where user-defined
coverageIncludepatterns in Vitest could incorrectly exclude bundled virtual files during the pre-sourcemap coverage check, leading to incomplete or empty coverage reports.This change modifies the
generateCoverageOptionfunction to augment user-providedcoverageIncludearrays with specific globs (spec-*.js,chunk-*.js) that match the internal bundled test entry points and code chunks. This ensures that all necessary files are considered during Vitest's initial coverage pass, while still respecting the user's originalincludepatterns for the post-sourcemap remapping.Closes #31828