docs(withResource): mention how to patch resource state#282
Merged
rainerhahnekamp merged 4 commits intomainfrom Jan 25, 2026
Merged
docs(withResource): mention how to patch resource state#282rainerhahnekamp merged 4 commits intomainfrom
withResource): mention how to patch resource state#282rainerhahnekamp merged 4 commits intomainfrom
Conversation
rainerhahnekamp
requested changes
Jan 22, 2026
docs/docs/with-resource.md
Outdated
| ); | ||
|
|
||
| // Unnamed resource: `value` | ||
| patchState(store, { value: undefined }); |
Collaborator
There was a problem hiding this comment.
For both named and unnamed: Maybe we don't want to update a resource in a non-resolved status. So I wouldn't use undefined or `[];
What about something in the direction of
patchState(store, { value: { id: 1, name: 'John' } });
patchState(store, ({ listValue }) => { listValue: [...listValue, { id: 1, name: 'John' }]})
rainerhahnekamp
requested changes
Jan 23, 2026
Collaborator
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Will you apply the changes we discussed? Explaining the impact that undefined value vs. previous value has?
rainerhahnekamp
requested changes
Jan 25, 2026
rainerhahnekamp
approved these changes
Jan 25, 2026
Collaborator
|
Thanks @michael-small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wondered how, imagined this was how, and saw that the JSDoc mentions this. But no doc mention until now.
Closes #281