feat(core): add support for tsconfig wildcard paths#571
Open
SteveVanOpstal wants to merge 3 commits intoangular-architects:mainfrom
Open
feat(core): add support for tsconfig wildcard paths#571SteveVanOpstal wants to merge 3 commits intoangular-architects:mainfrom
SteveVanOpstal wants to merge 3 commits intoangular-architects:mainfrom
Conversation
John-Pier
reviewed
Oct 30, 2024
Comment on lines
+73
to
+78
| if (!entry.includes('index.ts') && !entry.includes('index.js')) { | ||
| continue; | ||
| } | ||
|
|
||
| const capturedPath = mm.capture(path, entry); | ||
| if (!capturedPath) { |
There was a problem hiding this comment.
I don't know exactly how micromatch works, but...
Angular (ng-packagr) uses "ng-package.json" with lib.entryFile in secondary entry point to define entryFile of the point;
Almost always this is an index.ts file, but it is still worth considering ng-package.json
manfredsteyer
force-pushed
the
main
branch
4 times, most recently
from
93c1fc5 to
18c2874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a large project we use libraries with secondary entry points and map them in our
tsconfig.jsonlike this:"@aztrix/components/*": ["libs/components/*/index.ts"],It's a neat shorthand and easy way to create more secondary entry points without changing any configuration.
Therefore I've implemented a way to handle these kinds of path mappings.
Kind Regards