Support for PIC18 and SSD1309 Controller#9
Open
david-dego wants to merge 3 commits intoandygock:masterfrom
Open
Support for PIC18 and SSD1309 Controller#9david-dego wants to merge 3 commits intoandygock:masterfrom
david-dego wants to merge 3 commits intoandygock:masterfrom
Conversation
Owner
|
@david-dego Thanks for the contribution. I just wanted to check, is |
Author
|
Hi Andy,
It’s probably from windows directly as i don’t recall going through any sort of effort to get it.
Feel free to remove it during the merge.
Cheers
… Le 3 juil. 2021 à 15:46:03, Andy Gock ***@***.***> a écrit :
@david-dego <https://github.com/david-dego> Thanks for the contribution.
I just wanted to check, is fonts/Tahoma10x11.h generated from the proprietary Microsoft font? If so, I can't add it to the project. But there is an open source Tahoma variant <https://source.winehq.org/git/wine.git/tree/HEAD:/fonts> which comes from the Wine project - that one would be okay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABS2QCJAPFEPU364EVDWFP3TV4IBXANCNFSM47WRHBLA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added support for PIC18 mcus (tested with PIC18F26K80)
Only supporting ST7565R and SSD1309 (which has been added in the controller list)
SSD1309 should work with SPI or I2C regarding declaration of GLCD_CONTROLLER_SSD1309_SPI
I2C as not been tested as extensively as SPI though
Not sure about authoring and copyright stuff. Feel free to arrange it as you wish.
Regards