Adds HDR bitmap support to the image playback pipeline - #3351
Adds HDR bitmap support to the image playback pipeline#3351SathyaTadepalli wants to merge 2 commits into
Conversation
Derive the HardwareBuffer pixel format from `Bitmap.Config` (RGBA_1010102, RGBA_F16, or 8-bit fallback) instead of special-casing 10-bit as HDR. Try the `Bitmap.copy(Config.HARDWARE)` path first for all configs and only fall back to the CPU/JNI copy when the HARDWARE copy is unavailable or silently downgraded the source bit depth. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for creating this PR! While I start taking a look at the code, could you please ensure you've completed the Pull Request checklist in CONTRIBUTING.md? Please verify that you have signed the Google CLA, as we're unable to merge the PR without it. Let us know once that's sorted! |
| * depth is 8 bpc or unknown. | ||
| */ | ||
| private static int getHardwareBufferPixelFormat(@Nullable Config config) { | ||
| if (config == Config.RGBA_1010102) { |
There was a problem hiding this comment.
Config.RGBA_1010102 was added in API 33. Since this class is @RequiresApi(26), accessing this directly on older APIs will crash. Let's add an API check here: if (SDK_INT >= 33 && config == Config.RGBA_1010102) { ... }
|
I did the code review and the change looks good. I've left a comment about a potential crash that can happen. Once this is addressed, I'll go ahead and pull the PR in for internal review and add the necessary Robolectric tests so you don't have to worry about them. Regarding the CLA check: Thanks for signing the CLA! I can see your signature went through, but the check is still failing because of the second commit, 99fdad2. It looks like there's a To get this check to pass, can you see what we can do about it? Maybe remove the co-author if possible? Let me know what happens! |
|
I can create a new branch and create a new PR to avoid the claude. I will also implement your review comments |
|
I don't think there is a need to create a new branch and PR just for this. You can try simply editing the commit description using the interactive rebase instead. Here are the steps:
This will update the existing PR and hopefully clear up the CLA check failure! |
|
Created the new PR #3354 |

Bug is https://partnerissuetracker.corp.google.com/issues/531143289
color space.