fix(featured-compose): update API dump after FakeConfigValues removal#148
Merged
kirich1409 merged 1 commit intomainfrom Apr 3, 2026
Merged
fix(featured-compose): update API dump after FakeConfigValues removal#148kirich1409 merged 1 commit intomainfrom
kirich1409 merged 1 commit intomainfrom
Conversation
FakeConfigValues and FakeConfigValuesScope were removed from featured-compose but the BCV API dump was not regenerated, causing apiCheck to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Review Summary by QodoUpdate featured-compose API dump after FakeConfigValues removal
WalkthroughsDescription• Remove deleted FakeConfigValues classes from API dump • Regenerate BCV API dump after class removal • Fix apiCheck failures on open PRs Diagramflowchart LR
A["FakeConfigValues removal"] -- "API dump out of sync" --> B["apiCheck failures"]
B -- "regenerate dump" --> C["API dump updated"]
C -- "remove deleted classes" --> D["apiCheck passes"]
File Changes1. featured-compose/api/jvm/featured-compose.api
|
Code Review by Qodo
1. Android API dump stale
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| public static final fun collectAsState (Ldev/androidbroadcast/featured/ConfigValues;Ldev/androidbroadcast/featured/ConfigParam;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State; | ||
| } | ||
|
|
||
| public final class dev/androidbroadcast/featured/compose/FakeConfigValuesKt { |
There was a problem hiding this comment.
1. Android api dump stale 🐞 Bug ≡ Correctness
This PR updates only the JVM API dump, but the Android API dump still declares FakeConfigValuesKt/FakeConfigValuesScope as public even though the source marks them internal, so android apiCheck will continue to fail. Update/regenerate the Android dump to match the current public API surface.
Agent Prompt
### Issue description
The Android BCV API dump for `featured-compose` is stale: it still exposes `FakeConfigValuesKt`/`FakeConfigValuesScope` even though these APIs are `internal` in source and were removed from the JVM dump in this PR.
### Issue Context
`featured-compose` applies the BCV plugin and maintains separate dumps under `featured-compose/api/android` and `featured-compose/api/jvm`. The JVM dump was updated, but the Android dump still contains the removed symbols.
### Fix Focus Areas
- featured-compose/api/android/featured-compose.api[1-18]
- featured-compose/src/commonMain/kotlin/dev/androidbroadcast/featured/compose/FakeConfigValues.kt[16-54]
- featured-compose/api/jvm/featured-compose.api[1-8]
### What to do
Regenerate or edit `featured-compose/api/android/featured-compose.api` so it no longer contains `FakeConfigValuesKt` and `FakeConfigValuesScope` (matching the current visibility in source and the updated JVM dump).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
Pull request overview
Updates the featured-compose Binary Compatibility Validator (BCV) API dump to reflect the removal/hiding of FakeConfigValues APIs, unblocking apiCheck failures affecting other open PRs.
Changes:
- Regenerates
featured-composeJVM API dump to removeFakeConfigValuesKt/FakeConfigValuesScopeentries.
Comment on lines
4
to
7
|
|
||
| public final class dev/androidbroadcast/featured/compose/FakeConfigValuesKt { | ||
| public static final fun fakeConfigValues (Lkotlin/jvm/functions/Function1;)Ldev/androidbroadcast/featured/ConfigValues; | ||
| public static synthetic fun fakeConfigValues$default (Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Ldev/androidbroadcast/featured/ConfigValues; | ||
| } | ||
|
|
||
| public final class dev/androidbroadcast/featured/compose/FakeConfigValuesScope { | ||
| public static final field $stable I | ||
| public final fun set (Ldev/androidbroadcast/featured/ConfigParam;Ljava/lang/Object;)V | ||
| } | ||
|
|
||
| public final class dev/androidbroadcast/featured/compose/LocalConfigValuesKt { | ||
| public static final fun getLocalConfigValues ()Landroidx/compose/runtime/ProvidableCompositionLocal; | ||
| } |
There was a problem hiding this comment.
This updates the JVM API dump to remove FakeConfigValues*, but featured-compose/api/android/featured-compose.api still contains FakeConfigValuesKt / FakeConfigValuesScope. If those APIs were removed/hidden, the Android API dump likely also needs regeneration; otherwise apiCheck will continue to fail due to the stale Android dump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FakeConfigValuesandFakeConfigValuesScopewere removed fromfeatured-composebut the BCV API dump (featured-compose/api/jvm/featured-compose.api) was not regenerated, causingapiCheckto fail on all open PRs (#143, #144, #145).Test plan
Lint & API Checkpasses🤖 Generated with Claude Code