verifier_tools/verifier: Add support to verify mainline modules.#12
Conversation
- added public key for mainline module log. - added configs to recognize mainline module logs in `verifier.go` and `checkpoint.go`. Tests: `go test ./...` passed. Change-Id: Ia3f22790f37ff3a2f35e150d257447fa07ec7fe0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for verifying Android Mainline Module Transparency Logs. It introduces new constants, embeds the mainline module log public key, updates the CLI flags, and handles the new checkpoint origin originIDMainlineModule during parsing. The review feedback points out that the default error message in parseCheckpoint was not updated to include the new originIDMainlineModule origin, which could lead to misleading error messages.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| case strings.HasPrefix(ckpt, originIDMainlineModule): | ||
| body = ckpt[len(originIDMainlineModule):] |
There was a problem hiding this comment.
The error message in the default case of parseCheckpoint (line 127) was not updated to include the new originIDMainlineModule. It should be updated to list all four supported origins to avoid misleading error messages when an invalid checkpoint is parsed.
For example:
default:
return Root{}, fmt.Errorf("invalid checkpoint - unknown origin, must be either %s, %s, %s, or %s", originIDPixel, originIDG1P, originIDG1PAPK, originIDMainlineModule)1 participant
verifier.goandcheckpoint.go.Tests:
go test ./...passed.Change-Id: Ia3f22790f37ff3a2f35e150d257447fa07ec7fe0