added changes for fedora checks#18128
Open
404ram wants to merge 1 commit intoandresriancho:masterfrom
Open
Conversation
Owner
|
Thanks for the PR! The changes look good, but they are not backward-compatible. In other words, if I merge your change the dependency check for the old fedora distributions will fail. Please take a look at how this is handled for Ubuntu ( |
Author
|
Great thanks,
I will take a look when I get some free time and will let you know if I do
it.
Regards,
…On Tue, 17 Sep 2019 at 22:06, Andres Riancho ***@***.***> wrote:
Thanks for the PR! The changes look good, but they are not
backward-compatible. In other words, if I merge your change the dependency
check for the old fedora distributions will fail.
Please take a look at how this is handled for Ubuntu (ubuntu*.py files in this
directory
<https://github.com/andresriancho/w3af/tree/master/w3af/core/controllers/dependency_check/platforms>)
and submit new changes that properly handle both old and new Fedora
versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18128?email_source=notifications&email_token=AH6PFRD6TOGCFDSJWAZYQMDQKFBFFA5CNFSM4IVG5A42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD655A3I#issuecomment-532402285>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH6PFREPCVBEKXXHO7GMGKTQKFBFFANCNFSM4IVG5A4Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New fedora 30 packages for
python-pipandpython-develrenamed topython2-*and command for pip renamed topip