Update picker.date.js#1162
Open
Shimul22 wants to merge 1 commit intoamsul:masterfrom
Open
Conversation
Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not
Author
|
If setAsMaxYear: true --> then the current year will be treated as the last year/max year (in the dropdown) If setAsMaxYear: false (or not included) --> Then numberYears will be added after current year This will solve #1161 |
Contributor
|
Hi @Shimul22, Thanks for the PR. Please update the title and commit message and provide some tests if possible. Can you add this for v5? v3 is not actively developed anymore. |
Author
Can you tell me what do mean by the title?
Version v5 means future origin? |
Contributor
This title / message is not sufficient. Please change it do describe your changes. See the other PRs. |
Contributor
Exactly. This is a full rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not