🛡️ Sentinel: Fix XSS vulnerability in markdown link sanitization - #130
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Replaced regex blacklist in MessageBubble link rendering with a strict protocol allowlist (#, /, http:, https:, mailto:, tel:) after stripping whitespace and ASCII control characters.
🎯 Impact: Prevents potential Stored/Reflected XSS attacks via obfuscated URL schemes (e.g. java\tscript:) or non-blacklisted executable protocols (e.g. blob:, file:).
🔧 Fix: Implemented isSafeUrl helper that normalizes candidate URLs by removing whitespace and control characters before validating against the protocol allowlist.
✅ Verification: Added unit tests covering tab-obfuscated protocols and non-allowlisted URI schemes in message-bubble.test.tsx. All 135 unit tests pass cleanly.
PR created automatically by Jules for task 7009077310232854602 started by @amrabed