✨ Taboola amp privacy fallback - #40537
Open
Michalkals wants to merge 2 commits into
Open
Conversation
If the primary loader (cdn.taboola.com/.../loader.js) is blocked by private browsing / tracking protection treating taboola.com as a tracker, fall back to the privacy loader served from the clean domain (static.tblcontent.com/.../loader.privacy.js). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fire an unconditional GET to static.qovani.com (clean domain) on every page view, independent of whether the primary loader or the privacy loader fallback succeeds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
Author
|
Hi @calebcordry / @ampproject/wg-ads-reviewers This is a small change that adds a fallback so ads keep serving when the primary cdn.taboola.com loader is blocked/unavailable, plus a lightweight telemetry pixel to confirm the adapter ran. This is currently impacting live publisher pages on our side, so we'd really appreciate a review (or a pointer to the right owner) whenever you get a chance. happy to make any changes needed 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Taboola AMP adapter has a single point of failure: it loads its runtime from
cdn.taboola.com. When that CDN loader is blocked or unavailable, Taboola servesnothing on the page. This PR adds a privacy-loader fallback so ads keep serving,
plus a lightweight telemetry pixel on a clean domain to get a reliable per-page-view
signal that the adapter ran.