🐛 Block spaced !important in inline style sanitizer - #40536
Open
madib06ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INVALID_INLINE_STYLE_REGEX is the only CSS-level check isValidAttr runs on an inline style attribute, and its !important token assumes no whitespace between the ! and important. CSS permits whitespace there and browsers honor color:red ! important as an important declaration, so an author or template value like color:blue ! important slips past the denylist and lands in the DOM after reaching the purifier through amp-mustache, amp-bind [style], or amp-list, letting it override AMP protective !important rules. Relax the token to !\s*important so the spaced and tabbed forms are caught while valid styles and the existing position rules stay unchanged.