🏗 Only run package-lock.json sync check on PRs#40495
Merged
erwinmombay merged 1 commit intoampproject:mainfrom Mar 3, 2026
Merged
🏗 Only run package-lock.json sync check on PRs#40495erwinmombay merged 1 commit intoampproject:mainfrom
erwinmombay merged 1 commit intoampproject:mainfrom
Conversation
erwinmombay
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that verifies that
package-lock.jsonhas been synced correctly occasionally break on different environments (e.g., CircleCI vs. GitHub Actions) because those envs have different versions of npm, e.g. this recent breakage. In hindsight it doesn't seem to make sense to run this test on push builds - it should only ever be cause at the PR level