Docs: Add build and development instructions to README.md#40414
Open
moglione wants to merge 4 commits intoampproject:mainfrom
Open
Docs: Add build and development instructions to README.md#40414moglione wants to merge 4 commits intoampproject:mainfrom
moglione wants to merge 4 commits intoampproject:mainfrom
Conversation
This commit adds a "Build and Development" section to the README.md file. This section provides clear instructions on how to install dependencies, build the project, and run the development server. It also clarifies that the project uses a custom build system.
|
|
This commit adds a new file, amp-story-player-instructions.md, which contains instructions on how to build and run the amp-story-player component in isolation. This helps developers who want to work on this specific component without building the entire project.
This commit implements a vertical swipe navigation for the amp-story-player component, similar to TikTok. The gesture handling logic has been updated to detect vertical swipes, and the CSS animations have been adjusted to create a smooth vertical transition between stories. This also includes documentation on how to build and serve the component in isolation.
This commit refactors the amp-story-player component to use a vertical swipe navigation, similar to TikTok. Key changes: - The gesture handling logic in amp-story-player-impl.js has been updated to detect vertical swipes (swipe up to advance, swipe down to go back). - The CSS animations in amp-story-player-shadow.css have been adjusted to create a smooth, fluid vertical transition between stories. - Mobile compatibility has been ensured by updating the iframe capabilities to explicitly allow vertical swipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a "Build and Development" section to the README.md file. This section provides clear instructions on how to install dependencies, build the project, and run the development server. It also clarifies that the project uses a custom build system.