Skip to content

Added PHP 8.4 compatibility #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trowski merged 1 commit into from
Nov 23, 2024
Merged

Added PHP 8.4 compatibility #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
- operating-system: 'ubuntu-latest'
php-version: '8.3'

- operating-system: 'ubuntu-latest'
php-version: '8.4'

- operating-system: 'windows-latest'
php-version: '8.3'
job-description: 'on Windows'
Expand Down
6 changes: 3 additions & 3 deletions src/SqlConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ final public function getUser(): ?string
return $this->user;
}

final public function withUser(string $user = null): static
final public function withUser(?string $user = null): static
{
$new = clone $this;
$new->user = $user;
Expand All @@ -113,7 +113,7 @@ final public function getPassword(): ?string
return $this->password;
}

final public function withPassword(string $password = null): static
final public function withPassword(?string $password = null): static
{
$new = clone $this;
$new->password = $password;
Expand All @@ -125,7 +125,7 @@ final public function getDatabase(): ?string
return $this->database;
}

final public function withDatabase(string $database = null): static
final public function withDatabase(?string $database = null): static
{
$new = clone $this;
$new->database = $database;
Expand Down