fix(InstallWizard): reassure users when read is disabled but subscribe is active#1605
Draft
fix(InstallWizard): reassure users when read is disabled but subscribe is active#1605
Conversation
…e is active When an integration uses both read and subscribe for the same object and an end user clicks "Stop reading from [Object]", the UI previously showed only the red "Reading is currently disabled. This object is not being synced." callout. For subscribe-only customers (e.g. Outreach) this read as the integration being broken, even though events were still flowing. Render a follow-up success panel beneath the existing callout that lists the subscribed events (created/updated/deleted/other) for the selected object. The panel only appears when read for that object is disabled AND installation.config.content.subscribe.objects[name] is defined, so non- subscribe integrations are unchanged. The panel reflects amp.yaml config, not delivery telemetry, and discloses that limitation in a footnote. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installation.config.content.read.objects[X].disabled === trueANDinstallation.config.content.subscribe?.objects?.[X]being defined, so non-subscribe integrations and read-only objects are unchanged.amp.yamlconfiguration, not delivery telemetry (footnote discloses this).Why
A customer (Outreach) reported their end users believed the integration was broken after disabling read on a subscribe-only setup — the UI showed only "Reading is currently disabled. This object is not being synced." with no acknowledgment that events were still flowing.
Files
src/components/Configure/content/fields/SubscribeStillActiveBox.tsx— presentational panel, listscreateEvent/updateEvent/deleteEvent/otherEventsfromSubscribeConfigObject.src/components/Configure/content/fields/ReEnableReadObject.tsx— reads subscribe config for selected object, renders the panel only when both gating conditions hold.Test plan
ReEnableReadObjectearly-returnsnull(existing behavior); panel never mounts.yarn lintclean (0 errors; pre-existing warnings only).yarn buildpasses (tsc + vite + dts).Out of scope / follow-ups
lastEventAt, webhook health). Requires backend work.InstalledSuccessBoxwhen an integration is subscribe-only and skips the wizard entirely.🤖 Generated with Claude Code