[ENG-2451] build(oauth): use projectIdOrName on /oauth-connect#1603
Merged
[ENG-2451] build(oauth): use projectIdOrName on /oauth-connect#1603
Conversation
Backend (amp-labs/server#3839) and OpenAPI spec (amp-labs/openapi#354) now accept project name in addition to UUID on /oauth-connect. Regenerate the SDK and pass projectIdOrName straight from AmpersandProvider context, removing the unnecessary useProjectQuery() round-trip in the OAuth flow. The regenerated SDK also picks up unrelated providerInfo subscribe changes from amp-labs/openapi#352. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dionlow
force-pushed
the
eng/oauth-connect-project-id-or-name
branch
from
f159dd5 to
bd3ba43
Compare
dionlow
requested review from
a team and
RajatPawar
and removed request for
a team
dionlow
changed the title
dionlow
changed the title
RajatPawar
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth connect previously only supported projectId, we update to use projectIdorName.
/oauth-connectrequest body now usesprojectIdOrNameinstead ofprojectId.useOauthConnectQueryandOauthFlow2to the new field name.projectIdOrNamedirectly fromuseAmpersandProviderProps()instead of resolving the UUID viauseProjectQuery()first — removes an unnecessary fetch dependency from the OAuth flow.The regenerated SDK also picks up unrelated
providerInfosubscribe-support changes that already merged in amp-labs/openapi#352.Test plan
tsc --noEmitcleanyarn lintclean (0 errors)AmpersandProviderwith a project name (not UUID), trigger an OAuth flow viaOauthFlow2, verify thePOST /oauth-connectbody containsprojectIdOrNameand the connection is created