Skip to content

fix(frontend): offset error toast to prevent overlaying stop button#1689

Merged
markturansky merged 5 commits into
ambient-code:mainfrom
squizzi:fix/toast-position-and-dismissal
Jun 15, 2026
Merged

fix(frontend): offset error toast to prevent overlaying stop button#1689
markturansky merged 5 commits into
ambient-code:mainfrom
squizzi:fix/toast-position-and-dismissal

Conversation

@squizzi

@squizzi squizzi commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This PR offsets the error toast to prevent it from annoyingly covering the stop button within a chat. It also makes the toast dismissible so that if it does get in the users way they can close it.

Before

Screenshot 2026-06-15 at 2 18 48 PM

After

Screenshot 2026-06-15 at 2 15 16 PM

Summary by CodeRabbit

  • Style
    • Toast notifications are now positioned in the bottom-right corner with improved spacing and include a close button for user control.

Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for cheerful-kitten-f556a0 canceled.

Name Link
🔨 Latest commit 3942d65
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/6a3089754165670008ee965b

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ae07ddc5-12a1-48ca-b846-b3c0f692a7b8

📥 Commits

Reviewing files that changed from the base of the PR and between 5c41471 and ef4a4cc.

⛔ Files ignored due to path filters (1)
  • components/ambient-ui/package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json
📒 Files selected for processing (1)
  • components/frontend/src/components/ui/sonner.tsx

📝 Walkthrough

Walkthrough

The Toaster component in sonner.tsx adds three props to the underlying Sonner toaster: position="bottom-right", offset="80px", and closeButton. No interface, logic, or other behavior changes.

Changes

Toaster Display Configuration

Layer / File(s) Summary
Toaster position, offset, and closeButton
components/frontend/src/components/ui/sonner.tsx
Adds position="bottom-right", offset="80px", and closeButton props to the Sonner Toaster component.
🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format (fix scope: description) and accurately describes the main change: offsetting the toast to prevent UI overlap.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PR introduces only static configuration properties (position, offset, closeButton) to the Toaster component with no algorithmic complexity, loops, API calls, or unbounded state.
Security And Secret Handling ✅ Passed Pure UI configuration changes (positioning, spacing, closeButton) with no secrets, injection vulnerabilities, auth issues, or sensitive data exposure.
Kubernetes Resource Safety ✅ Passed PR modifies only frontend UI component (sonner.tsx toast configuration), not Kubernetes manifests; custom check for K8s resource safety is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@markturansky

Copy link
Copy Markdown
Contributor

LGTM. Tests pass.

@markturansky markturansky merged commit 7e918dd into ambient-code:main Jun 15, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants