chore: hide private ssh key when on edit polydock store page#62
Open
chore: hide private ssh key when on edit polydock store page#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the security by moving the storage of the
lagoon_deploy_private_keyfrom a plain text column in thepolydock_storestable to an encrypted value in thepolydock_variablestableChanges:
2026_02_05_133703_move_lagoon_deploy_private_key_to_variables.phpto migrate existing keys to thepolydock_variablestable with encryption and drop thelagoon_deploy_private_keycolumn frompolydock_storesApp\Models\PolydockStoreto removelagoon_deploy_private_keyfrom$fillablegetLagoonDeployPrivateKeyAttributeto seamlessly retrieve the decrypted key from the variables relation, ensuring backward compatibilityApp\Console\Commands\CreateStoreto store the private key usingsetPolydockVariableValuewithencrypted => trueCreatePolydockStoreandEditPolydockStorepages to handle thelagoon_deploy_private_keyfield manually. The key is now intercepted during creation/update and stored securely via the variable helper, rather than being saved directly to the model.DatabaseSeeder,AmazeeTrialSeeder, andLocalstackSeederto use the secure storage method for creating stores with deploy keysgetPublicKeyFromPrivateKeyhelper inLagoonHelperto support key derivation for display in the UI.Security Implications:
Backward Compatibility:
getLagoonDeployPrivateKeyAttributeaccessor ensures that any existing code accessing$store->lagoon_deploy_private_keycontinues to work without modification, automatically fetching and decrypting the value.