Resolve direct PR links in issue-scoped tools#168
Merged
Conversation
54ae336 to
d876061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paperclip-github-plugin.pull-request-linkentities when the Paperclip issue has no GitHub issue-origin linkCloses #167.
Why
create_pull_requestalready persisted a durable direct PR link for native Paperclip issues, but later tools such asget_pull_request({ paperclipIssueId })only consulted GitHub issue-origin metadata. That made the atomic create flow succeed and link the PR while immediate follow-up reads incorrectly reported that the issue was not linked.Verification
pnpm typecheckpnpm test— 262 passingpnpm buildgit diff --checkStaging
Deployed an unreleased
0.14.1-issue167.1build to the staging plugin worker and invoked the sameget_pull_requestcall with the original native Paperclip issue and completed staging run context.Before the fix:
After the fix:
alvarosanchez/paperclip#3closed6f24ec5bb463231f5473bd98333efda1a1c0c139The regression test covers atomic
create_pull_request→ durable direct link →get_pull_request({ paperclipIssueId }). A second test covers same-number direct PRs across repositories and requires an explicit matching repository.