fix(server): make Stop() complete when the accept loop is blocked - #7
Open
andreion1ca wants to merge 1 commit into
Open
fix(server): make Stop() complete when the accept loop is blocked#7andreion1ca wants to merge 1 commit into
andreion1ca wants to merge 1 commit into
Conversation
TcpListener.Stop() blocks indefinitely on Unix when the accept thread is parked in a blocking AcceptTcpClient(). Because Stop() never returned, the server stayed in ShuttingDown forever and a later Start() silently no-opped (its guard returns early in that state), leaving the server permanently unable to accept connections. - Poll the listening socket (250ms) before accepting, so the accept loop notices a shutdown and exits on its own instead of blocking in Accept. - Join the receive thread before disposing the listener in stopReceiving(), so no thread is parked in Accept when the socket is closed. - Set SendTimeout on accepted sockets so a write to a peer that has gone unreachable (including the server-initiated close handshake) cannot block forever. This makes Stop()/Start() usable at runtime, which AltServer needs in order to stop serving while a subscription cannot be verified and resume once it can be verified again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TcpListener.Stop() blocks indefinitely on Unix when the accept thread is parked in a blocking AcceptTcpClient(). Because Stop() never returned, the server stayed in ShuttingDown forever and a later Start() silently no-opped (its guard returns early in that state), leaving the server permanently unable to accept connections.
This makes Stop()/Start() usable at runtime, which AltServer needs in order to stop serving while a subscription cannot be verified and resume once it can be verified again.