PSO fixes#452
Conversation
uyraq2001
force-pushed
the
master
branch
6 times, most recently
from
6bad810 to
1a30390
Compare
| * ADMC - AD Management Center | ||
| * | ||
| * Copyright (C) 2020-2025 BaseALT Ltd. | ||
| * Copyright (C) 2020-2025 Dmitry Degtyarev |
There was a problem hiding this comment.
I think you need to put here another line with copyright date and your name, if you are one of the authors of the file.
| * ADMC - AD Management Center | ||
| * | ||
| * Copyright (C) 2020-2025 BaseALT Ltd. | ||
| * Copyright (C) 2020-2025 Dmitry Degtyarev |
There was a problem hiding this comment.
The same comment about the copyright header here.
| }); | ||
| } | ||
|
|
||
| void PasswordSettingsImpl::fetch(const QModelIndex &index) { |
There was a problem hiding this comment.
I'd put a Doxygen comment before methods, to document what the method does, what it accepts as parameters, what it asserts (if it does so) and what it returns. Also, if there are any exceptions that can be thrown in the method, I'd document them too.
|
|
||
| ui->applied_list_widget->clear(); | ||
|
|
||
| ui->name_edit->setReadOnly(true); |
There was a problem hiding this comment.
It breaks PSO objects UI name edition. Remove that line please. If you wanna setup specific configuration for this widget you can use enum (for ctor) or setter f-n.
There was a problem hiding this comment.
For global settings, the name field will always be empty. It shouldn't be displayed like other empty settings fields.
Also, the header "Default password settings" would be better for the global case instead of "Password settings".
| ui->edit_button->setDisabled(true); | ||
| ui->cancel_button->setDisabled(true); | ||
| ui->apply_button->setDisabled(true); | ||
| pso_edit_widget->set_read_only(true); |
There was a problem hiding this comment.
If all buttons are disabled, it's better to just hide them.
| QAction *create_pso_action; | ||
| }; | ||
|
|
||
| void password_settings_impl_add_objects(ConsoleWidget *console, const QList<AdObject> &object_list, const QModelIndex &parent); |
| else if (object.is_class(CLASS_SUBNET)) { | ||
| stacked_widget->setCurrentWidget(subnet_results_widget); | ||
| subnet_results_widget->update(object); | ||
| } |
There was a problem hiding this comment.
Did u move that commit to another PR?
Removed title from PSO edit widget since no other edit widget has one and title dublicates description bar label
|
Hi! I think it would be better if we would provide at least some overview of the work we've done in the PR description, aside from the PR title. Here we have 11 commits and no information provided. That means a reviewer will have hard time figuring out what the author of those changes wanted to accomplish by this work. |
3 participants
No description provided.