fix(visitor-plugin-common): keep deferred fields optional with overlapping named @defer spreads#1
Closed
redox wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Opened upstream instead: will link after create |
Member
Author
|
Opened upstream instead: dotansimha#10898 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@defer/@streamfragment spreads were typed as a single union of all fragment fields. When a field likeidwas also selected outside the spread, intersecting with the required outer field eliminated the absent branch and made deferred-only fields required.@defer) so each deferred field stays its own optional union. Fragment masking (inlineFragmentTypes: "mask") is unchanged and still usesIncremental<>fragment refs.Test plan
id+ named@defer(fails before fix, passes after)@defer/@skip+@defersnapshots for per-field unionsvitestincremental delivery + skip/include defer suites green@defertests greenMade with Cursor