fix(cli): ignore unrelated Altertable environment variables#67
Merged
Conversation
leonkenneth
approved these changes
Jul 16, 2026
francoischalifour
enabled auto-merge (squash)
July 16, 2026 13:40
leonkenneth
added a commit
that referenced
this pull request
Jul 16, 2026
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2026-07-16) ### Features * **update:** simplify `update` command behavior and API ([#64](#64)) ([310acdf](310acdf)) ### Bug Fixes * **cli:** ignore unrelated Altertable environment variables ([#67](#67)) ([8fe9041](8fe9041)) * **release:** checkout merge commit for draft release verification ([#58](#58)) ([988c95d](988c95d)) * **release:** run recovery with current publication code ([#63](#63)) ([eab2c4a](eab2c4a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Léo-Paul Goffic <leo.goffic@altertable.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The CLI recently centralized environment-variable access behind a typed schema and added startup validation for every
ALTERTABLE_*variable.This improved configuration safety by:
However, startup validation also assumed that every inherited variable beginning with
ALTERTABLE_belonged to the CLI. Unknown names caused an immediate configuration error.That assumption is too broad for automation and CI workflows. For example, a workflow may define domain-specific variables such as:
These values are expanded into explicit CLI flags:
Although these variables do not configure the CLI directly, they are inherited by the CLI process. The previous validation rejected them before command parsing or execution, causing otherwise valid commands to fail.
The same startup ordering also meant environment validation ran before informational
--helpand--versionexits. An invalid known configuration variable could therefore prevent users from accessing help or checking the installed version.Proposed solution
Separate validation of the CLI’s known configuration surface from ownership of the broader
ALTERTABLE_*namespace.This change:
ALTERTABLE_*variables.--helpand--versionbefore startup environment validation.Known variables still retain their existing validation behavior. For example, this remains an error:
ALTERTABLE_UPDATE_SOURCEis a recognized CLI setting, butgitlabis not one of its accepted values.Unrelated workflow variables no longer affect execution:
Behavioral changes
Before this change:
ALTERTABLE_*variable caused exit code10.--helpand--version.After this change:
ALTERTABLE_*variables are ignored.--helpand--versionremain available even when a known environment setting is invalid.