Adds py.typed and fixes mypy issues#205
Open
palfrey wants to merge 2 commits intoaltdesktop:masterfrom
Open
Conversation
i3ipc now has no complaints from mypy
Contributor
|
Any progress with this? |
Contributor
|
Okay, I tested this and it has a lot of problems with |
Contributor
|
|
Contributor
|
I created a new PR with full annotations: #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i3ipc now has no complaints from mypy. This fixes #187.
My current test setup is:
pip install mypy types-python-xlibtestfolder.(cd .. && pip install . && python -m mypy . --exclude build --exclude examples --exclude docs --exclude setup.py)as I made changes until it stopped breaking.jazzband/dj-database-url@7ee1eea demos this sort of check in CI environment, but can't do that here yet because of #204.