Skip to content

fcplay/cplay: Improve information printout regarding to buffer configuration and track playback progression #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujfalusi wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fcplay/cplay: Improve information printout regarding to buffer configuration and track playback progression #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b5ccf8
fcplay: Handle the buffer size and fragments command line parameters
ujfalusi Mar 17, 2026
12ce56e
cplay: Print out the number of fragments used in the buffer
ujfalusi Mar 18, 2026
9552e05
fcplay: Fix the buffer size print and print out the number of fragments
ujfalusi Mar 18, 2026
3cacca3
src: lib: compress: add playback info helper
ujfalusi Apr 29, 2026
387062c
src: lib: compress: print track index for playback wip
ujfalusi Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/tinycompress/tinycompress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,12 @@ int is_compress_ready(struct compress *compress);
/* Returns a human readable reason for the last error */
const char *compress_get_error(struct compress *compress);

/* Prints basic stream details for playback diagnostics */
void compress_print_playback_info(const char *name, unsigned int card,
unsigned int device, unsigned int file_count,
unsigned int file_idx, unsigned long buffer_size,
unsigned int num_fragments, const struct snd_codec *codec);

/*
* compress_set_param: set codec config intended for next track
* if DSP has support to switch CODEC config during gapless playback
Expand Down
16 changes: 16 additions & 0 deletions src/lib/compress.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,22 @@ const char *compress_get_error(struct compress *compress)
return compress->ops->get_error(compress->data);
}

void compress_print_playback_info(const char *name, unsigned int card,
unsigned int device, unsigned int file_count,
unsigned int file_idx, unsigned long buffer_size,
unsigned int num_fragments, const struct snd_codec *codec)
{
if (file_count > 1)
printf("Playing file %u/%u %s On Card %u device %u\n", file_idx + 1,
file_count, name, card, device);
else
printf("Playing file %s On Card %u device %u\n", name, card, device);
printf(" Buffer size: %lu bytes, %u fragments, fragment size: %lu bytes\n",
buffer_size, num_fragments, buffer_size / num_fragments);
printf(" Format %u Channels %u, %u Hz, Bit Rate %d\n",
codec->id, codec->ch_in, codec->sample_rate, (int)codec->bit_rate);
}

int is_compress_running(struct compress *compress)
{
return compress->ops->is_compress_running(compress->data);
Expand Down
71 changes: 46 additions & 25 deletions src/utils-lgpl/fcplay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,16 +351,25 @@ static int parse_file(const char *file, struct snd_codec *codec)
static struct compress *
compress_open_and_prepare(unsigned int card, unsigned int device,
struct snd_codec *codec, unsigned long buffer_size,
const char *name, FILE *file, char **buffer_out,
int *size_out)
unsigned int frag, const char *name, FILE *file,
char **buffer_out, unsigned long *total_size_out,
unsigned int *num_fragments_out)
{
struct compr_config config;
struct compress *compress;
int size, num_read, wrote;
int fragment_size, num_read, wrote;
char *buffer;

memset(&config, 0, sizeof(config));

if ((buffer_size != 0) && (frag != 0)) {
config.fragment_size = buffer_size / frag;
config.fragments = frag;
} else {
/* use driver defaults */
config.fragment_size = 0;
config.fragments = 0;
}
config.codec = codec;

compress = compress_open(card, device, COMPRESS_IN, &config);
Expand All @@ -373,17 +382,17 @@ compress_open_and_prepare(unsigned int card, unsigned int device,
if (verbose)
printf("%s: Opened compress device\n", __func__);

size = config.fragment_size;
buffer = malloc(size * config.fragments);
fragment_size = config.fragment_size;
buffer = malloc(fragment_size * config.fragments);
if (!buffer) {
fprintf(stderr, "Unable to allocate %d bytes\n",
size * config.fragments);
fragment_size * config.fragments);
compress_close(compress);
return NULL;
}

/* write full buffer data initially */
num_read = fread(buffer, 1, size * config.fragments, file);
num_read = fread(buffer, 1, fragment_size * config.fragments, file);
if (num_read > 0) {
if (verbose)
printf("%s: Doing first buffer write of %d\n", __func__, num_read);
Expand All @@ -402,7 +411,8 @@ compress_open_and_prepare(unsigned int card, unsigned int device,
}

*buffer_out = buffer;
*size_out = size;
*total_size_out = (unsigned long)fragment_size * config.fragments;
*num_fragments_out = config.fragments;
return compress;
}

Expand All @@ -413,7 +423,9 @@ void play_samples(char **files, unsigned int card, unsigned int device,
{
struct compr_gapless_mdata mdata;
struct compress *compress;
int size, num_read, wrote;
int fragment_size, num_read, wrote;
unsigned long allocated_buffer_size;
unsigned int num_fragments;
unsigned int file_idx = 0;
struct snd_codec codec;
char *buffer, *name;
Expand All @@ -428,19 +440,20 @@ void play_samples(char **files, unsigned int card, unsigned int device,

parse_file(name, &codec);
compress = compress_open_and_prepare(card, device, &codec, buffer_size,
name, file, &buffer, &size);
frag, name, file, &buffer,
&allocated_buffer_size, &num_fragments);
if (!compress)
goto FILE_EXIT;

fragment_size = (int)(allocated_buffer_size / num_fragments);

if (pb_mode == PLAYBACK_MODE_GAPLESS) {
memset(&mdata, 0, sizeof(mdata));
compress_set_gapless_metadata(compress, &mdata);
}

printf("Playing file %s On Card %u device %u, with buffer of %lu bytes\n",
name, card, device, buffer_size);
printf("Format %u Channels %u, %u Hz, Bit Rate %d\n",
codec.id, codec.ch_in, codec.sample_rate, codec.bit_rate);
compress_print_playback_info(name, card, device, file_count, file_idx,
allocated_buffer_size, num_fragments, &codec);

compress_start(compress);
if (verbose)
Expand All @@ -453,10 +466,6 @@ void play_samples(char **files, unsigned int card, unsigned int device,
if (!file)
goto TRACK_EXIT;

if (verbose)
printf("Playing file %s On Card %u device %u, with buffer of %lu bytes\n",
name, card, device, buffer_size);

if (pb_mode == PLAYBACK_MODE_GAPLESS) {
int rc;

Expand All @@ -478,6 +487,11 @@ void play_samples(char **files, unsigned int card, unsigned int device,
rc = compress_partial_drain(compress);
if (rc)
fprintf(stderr, "ERR: partial drain\n");

compress_print_playback_info(name, card, device,
file_count, file_idx,
allocated_buffer_size,
num_fragments, &codec);
} else if (pb_mode == PLAYBACK_MODE_RESTART) {
/* restart: drain, close, and reopen for the new file */
compress_drain(compress);
Expand All @@ -486,24 +500,31 @@ void play_samples(char **files, unsigned int card, unsigned int device,

parse_file(name, &codec);
compress = compress_open_and_prepare(card, device, &codec,
buffer_size, name,
file, &buffer, &size);
buffer_size, frag, name,
file, &buffer,
&allocated_buffer_size,
&num_fragments);
if (!compress)
goto FILE_EXIT;

printf("Playing file %s On Card %u device %u, with buffer of %lu bytes\n",
name, card, device, buffer_size);
printf("Format %u Channels %u, %u Hz, Bit Rate %d\n",
codec.id, codec.ch_in, codec.sample_rate, codec.bit_rate);
fragment_size = num_fragments ? (int)(allocated_buffer_size / num_fragments) : 0;

compress_print_playback_info(name, card, device,
file_count, file_idx,
allocated_buffer_size,
num_fragments, &codec);

compress_start(compress);
if (verbose)
printf("%s: You should hear audio NOW!!!\n", __func__);
} else if (verbose) {
printf("Playing file %s On Card %u device %u, with buffer of %lu bytes, %u fragments\n",
name, card, device, allocated_buffer_size, num_fragments);
}
}

do {
num_read = fread(buffer, 1, size, file);
num_read = fread(buffer, 1, fragment_size, file);
if (num_read > 0) {
wrote = compress_write(compress, buffer, num_read);
if (wrote < 0) {
Expand Down
6 changes: 2 additions & 4 deletions src/utils/cplay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,10 +844,8 @@ void play_samples(char *name, unsigned int card, unsigned int device,
fprintf(stderr, "We wrote %d, DSP accepted %d\n", num_read, wrote);
}
}
printf("Playing file %s On Card %u device %u, with buffer of %d bytes\n",
name, card, device, size);
printf("Format %u Channels %u, %u Hz, Bit Rate %d\n",
codec.id, codec.ch_in, codec.sample_rate, codec.bit_rate);
compress_print_playback_info(name, card, device, 1, 0, (unsigned long)size,
config.fragments, &codec);

compress_start(compress);
if (verbose)
Expand Down