Open
Conversation
Add tests for various features of the PCM interface. The goal is to maximize coverage of the corresponding kernel code. The tests use a loopback device and require snd-aloop kernel module to be loaded.
Author
|
@perexg Can you please review? |
perexg
requested changes
Nov 7, 2023
Member
perexg
left a comment
perexg
left a comment
There was a problem hiding this comment.
This is test for the Loopback driver, so it may make sense to rename the main source file from pcm.c to pcm-loopback.c or so. Or create a more universal code which allows to pass the card number/name by user.
Possible improvement (maybe for future update): Add a time check for the I/O operations using the system clock.
| #include <stdio.h> | ||
| #include <alsa/asoundlib.h> | ||
|
|
||
| /* XXX this variable definition does not belong in a header file */ |
| static char opcmdev[10], ipcmdev[10]; | ||
|
|
||
| static int find_card(int *card_index) { | ||
| int index = -1; |
Member
There was a problem hiding this comment.
Please, use one intention style for the whole code. Check also whitespaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for various features of the PCM interface. The goal is to maximize coverage of the corresponding kernel code. The tests use a loopback device and require snd-aloop kernel module to be loaded.