Skip to content

build(emscripten): omit unix/posix-poll.c for emscripten targets#11

Merged
torque merged 1 commit into
allyourcodebase:masterfrom
Rawan10101:emscripten-wasm-support
Jun 19, 2026
Merged

build(emscripten): omit unix/posix-poll.c for emscripten targets#11
torque merged 1 commit into
allyourcodebase:masterfrom
Rawan10101:emscripten-wasm-support

Conversation

@Rawan10101

Copy link
Copy Markdown
Contributor

This change removes unix/posix-poll.c from the Emscripten source list. The file provides the POSIX-based implementation of uv__io_poll(), which is not directly usable in Emscripten's event-driven WASM environment. So, excluding it allows Emscripten targets to provide their own platform specific implementation of uv__io_poll() without symbol conflicts.

@torque

torque commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

If it doesn't work, then it makes sense to get rid of it, but I wonder if the libuv maintainers would be receptive to merging an upstream implementation of an emscripten compatible event loop so that every downstream user doesn't have to implement it themselves.

@torque torque merged commit c1ccce2 into allyourcodebase:master Jun 19, 2026
9 checks passed
@Rawan10101

Copy link
Copy Markdown
Contributor Author

If it doesn't work, then it makes sense to get rid of it, but I wonder if the libuv maintainers would be receptive to merging an upstream implementation of an emscripten compatible event loop so that every downstream user doesn't have to implement it themselves.

I was wondering about this as well. I can open an issue to raise the concern and get feedback from the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants