build(emscripten): omit unix/posix-poll.c for emscripten targets#11
Merged
torque merged 1 commit intoJun 19, 2026
Merged
Conversation
Collaborator
|
If it doesn't work, then it makes sense to get rid of it, but I wonder if the libuv maintainers would be receptive to merging an upstream implementation of an emscripten compatible event loop so that every downstream user doesn't have to implement it themselves. |
Contributor
Author
I was wondering about this as well. I can open an issue to raise the concern and get feedback from the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes
unix/posix-poll.cfrom the Emscripten source list. The file provides the POSIX-based implementation ofuv__io_poll(), which is not directly usable in Emscripten's event-driven WASM environment. So, excluding it allows Emscripten targets to provide their own platform specific implementation ofuv__io_poll()without symbol conflicts.