Use alisw/CGAL mirror instead of tarballs#6145
Open
singiamtel wants to merge 3 commits intoalisw:masterfrom
Open
Use alisw/CGAL mirror instead of tarballs#6145singiamtel wants to merge 3 commits intoalisw:masterfrom
singiamtel wants to merge 3 commits intoalisw:masterfrom
Conversation
singiamtel
force-pushed
the
pr-use-cgal-mirror
branch
from
46e6831 to
ad31b99
Compare
ktf
reviewed
Feb 20, 2026
ktf
reviewed
Mar 4, 2026
| export GMP_INC_DIR="${GMP_ROOT}/include" | ||
|
|
||
| cmake "$SOURCEDIR" \ | ||
| -DCMAKE_CXX_STANDARD=14 \ |
Member
There was a problem hiding this comment.
In general we build for C++20. Why do we need to hardcode the 14? Shuldn't this be $CXXSTD from the default?
Collaborator
Author
There was a problem hiding this comment.
This version of CGAL uses std::allocator::rebind which is apparently gone since C++17. We would need to either bump or patch it away
singiamtel
force-pushed
the
pr-use-cgal-mirror
branch
from
d758ed1 to
9f67ed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.