Preparation to merge initial revision of sisbasekt#3
Draft
alikindsys wants to merge 44 commits intomasterfrom
Draft
Preparation to merge initial revision of sisbasekt#3alikindsys wants to merge 44 commits intomasterfrom
sisbasekt#3alikindsys wants to merge 44 commits intomasterfrom
Conversation
Those were delegated to `sisbase-commands`
This project was left hanging since its original intent got superseded by `sisbase-commands` becoming its own project and systems becoming first-class citizens of `sisbase-core`.
The functionality stopped being "just a parser" ages ago.
Extensions are an abstraction that are a part of core. As such there is no need to have a section about them on the api specifications.
alikindsys
commented
Aug 1, 2022
Comment on lines
+31
to
+37
| ```kt | ||
| package org.siscode.sisbasekt-backends.discord4j | ||
| class Discord4JBackend() : AbstractBackend { | ||
| public restBackend = Discord4JRest(); | ||
| public gatewaybackend = Discord4JGateway() | ||
| } | ||
| ``` |
Owner
Author
There was a problem hiding this comment.
This code snippet is non-descriptive and only duplicates the text above it.
|
|
||
| ## Dependencies | ||
| [types](types.md) | ||
|
|
Owner
Author
There was a problem hiding this comment.
Missing Features section
sisbasekt/core.md
Outdated
Comment on lines
16
to
17
| Systems can depend on other systems using the `@DependsOn` annotation. | ||
| Systems can add "soft dependencies" using the `@Extends` annotation. |
Owner
Author
There was a problem hiding this comment.
Missing Annotations section
Owner
Author
There was a problem hiding this comment.
Check feasibility of @Extends annotation
alikindsys
changed the title
sisbasektsisbasekt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered View
The project spec has achieved some maturity for the pull request to be opened for scrutiny.
All blocking problems must be solved and no new features can be added to the spec until this PR merges.
Current feature set for #3
sisbasekt.md- Overall project descriptioncommands.md- Command librarytypes.md- Shared discord types libraryapi.md- Abstracted Discord API implementationcore.md- Extension Loader/ Runtime