Conversation
This fixes a crash in the RansacLineFitter_TooFewPoints unit test, which is caused by a dangling reference: The constructor of the LineKernel class creates a temporary Eigen matrix instance (if the passed reference does not exactly match the defined Eigen template it expects) and stores a reference to it. Once the constructor returns, the reference in the LineKernel instance potentially becomes dangling. Storing an owned Eigen matrix (performing an implicit copy) removes the issue. Caught by LLVM ASAN: https://gist.github.com/philippremy/180bcc7d042755206f4261b57af41e11 Signed-off-by: Philipp Remy <philipp@philippremy.net>
[FIX] Remove potentially dangling reference from LineKernel.hpp
Co-authored-by: demoulinv <99878110+demoulinv@users.noreply.github.com>
…versions Update meshroomHub Python node versions in pipeline templates
Add missing openmp include
Adapt cmake to modern CUDA integration
Use LLVM openmp on windows
Fix array usage and add useAllSeeds option for checkerBoards
Rewrite imageProcessing app and adding parallelization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganization of AliceVision dependency management in several files.
Features list