Add a preprocessor in Turbo#548
Open
zzlin237 wants to merge 60 commits into
Open
Conversation
…efactor/turbo_preprocessor
…rocessor # Conflicts: # .gitignore
zzlin237
requested review from
chinaux,
egolearner,
feihongxu0824 and
richyreachy
as code owners
…n237/zvec into refactor/turbo_preprocessor
…c into refactor/turbo_quantizer
…nto refactor/turbo_preprocessor
…nto refactor/turbo_preprocessor
iaojnh
reviewed
Jul 15, 2026
|
|
||
| #pragma once | ||
|
|
||
| #include <turbo/quantizer/quantizer.h> |
Collaborator
There was a problem hiding this comment.
framework的头文件不应该依赖turbo的头文件，zvec::turbo::Quantizer应该使用前向声明来规避这个include
| int serialize(std::string *out) const override; | ||
| int deserialize(const void *data, size_t len) override; | ||
|
|
||
| //! Rotator type tag (kFht = 1). |
| void FhtRotator::apply_inverse(const float *in, float *out) const { | ||
| const size_t dim = static_cast<size_t>(in_dim_); | ||
| // Copy input into working buffer | ||
| std::vector<float> data(in, in + dim); |
Collaborator
There was a problem hiding this comment.
既然最后都要memcpy到out上，为何不一开始就在out上操作？这个data有点冗余。
Collaborator
Author
There was a problem hiding this comment.
apply改了，此处忘记改了，已解决
…c into refactor/turbo_quantizer
…nto refactor/turbo_preprocessor
egolearner
reviewed
Jul 16, 2026
| #include "scalar/rotate/fht/fht.h" | ||
|
|
||
| #if defined(__SSE2__) | ||
| #include "sse/rotate/fht/fht.h" |
Collaborator
There was a problem hiding this comment.
把 defined 判断放每个simd实现的内部头文件？这样include方比较简单，虽然当前pr没差别，只有一处include。
| #if defined(__AVX512F__) | ||
| if (zvec::ailego::internal::CpuFeatures::static_flags_.AVX512F && | ||
| zvec::ailego::internal::CpuFeatures::static_flags_.AVX512DQ && | ||
| (cpu_arch_type == CpuArchType::kAuto || |
Collaborator
There was a problem hiding this comment.
加个cpu arch type match的helper？
| switch (rotate_type) { | ||
| case RotateType::kFht: { | ||
| RotatorKernels k; | ||
| // Default: scalar |
Collaborator
There was a problem hiding this comment.
把scalar定义放最后吧，实现和使用间隔比较远
| zvec::ailego::internal::CpuFeatures::static_flags_.AVX512DQ && | ||
| (cpu_arch_type == CpuArchType::kAuto || | ||
| cpu_arch_type == CpuArchType::kAVX512)) { | ||
| k.rotate = avx512::fht_rotate_avx512; |
Collaborator
There was a problem hiding this comment.
可以用aggregation初始化，其他类似
return {avx512::fht_rotate_avx512, avx512::fht_unrotate_avx512};
| #if defined(__AVX2__) | ||
| #include "avx2/rotate/fht/fht.h" | ||
| #endif | ||
| #if defined(__AVX512F__) |
Collaborator
There was a problem hiding this comment.
turbo.cc编译时没开simd开关，这些if define实际不起作用？
| static constexpr FhtPrimitives kPrim = { | ||
| fht_flip_sign_avx2, fht_inplace_avx2, fht_kacs_walk_avx2, | ||
| fht_inv_kacs_walk_avx2, fht_vec_rescale_avx2}; | ||
| fht_rotate_impl(out, in_dim, ctx, kPrim); |
Collaborator
There was a problem hiding this comment.
in参数完全没用到，要求输入已经在out了，这个接口有问题吧？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: A preprocessor is an optional internal component of the Turbo quantizer, primarily responsible for preprocessing data prior to retrieval. Its main functionalities include rotation and dimensionality reduction. Currently, only FHT rotation has been implemented, with support for OPQ rotation, dimensionality reduction, and other features planned for future releases.
Benefits: A module developed for Turbo