Optimize TransmittableThreadLocal.get() with Conditional Initialization via initialValueSupplierForQuickGet#795
Open
bigbear07 wants to merge 1 commit intoalibaba:masterfrom
Open
Conversation
…hreadLocal. Purpose: To reduce the overhead in get() method by calling addThisToHolder() only when value initialization is actually needed, rather than on every get() call
|
大熊 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
大熊 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title:
Optimize
TransmittableThreadLocal.get()with Conditional Initialization viainitialValueSupplierForQuickGetPR Description:
Overview
This PR introduces a performance optimization for
TransmittableThreadLocalby adding a new fieldinitialValueSupplierForQuickGetand corresponding constructors, enabling lazy initialization ofaddThisToHolder()only when necessary.Key Changes
initialValueSupplierForQuickGetto conditionally trigger optimization logic.get()Workflow:initialValueSupplierForQuickGet != null):Calls
addThisToHolder()only during value initialization (i.e., whenvalue == null).initialValueSupplierForQuickGet == null):Maintains original behavior for backward compatibility.
Performance Impact
Problem Solved:
The original implementation invoked
addThisToHolder()on everyget()call, incurring unnecessary overhead. The optimization reduces redundant synchronization by limitingaddThisToHolder()to initialization phases.Compatibility & Safety
initialValueSupplierForQuickGetis not provided.Verification
Why This Matters
This change significantly improves performance for frameworks relying on frequent
TransmittableThreadLocalaccess (e.g., thread-pool wrappers, context propagation), while preserving flexibility for legacy use cases.Review Focus Areas:
get()method (optimized vs. legacy paths)