fix: small fixes for AI reviewing feedback

[zhf999]

fix: small fixes for AI reviewing feedback

Purpose

A set of small fixes in the Parquet format reader module based on AI code review feedback:

• file_reader_wrapper.cpp:

  • Change pool_ initialization to use std::move(pool), avoiding an unnecessary shared_ptr copy
  • Change rg_id type from uint32_t to int32_t to match the row_group_index field type, eliminating implicit type mismatch
  • Add a TODO comment documenting the unbounded prebuffer cache issue — potential OOM and wasted IO from dropped prebuffered ranges

• page_filtered_row_group_reader.cpp/.h:

  • Change record_reader parameter in ExecuteSkipReadPattern from pass-by-value std::shared_ptr<...> to const std::shared_ptr<...>&, avoiding unnecessary reference count overhead

• parquet_file_batch_reader.cpp:

  • Rename page_filtered to is_partially_matched in TargetRowGroup construction, which more accurately reflects the semantics — the flag indicates whether a row group is partially matched, not whether it underwent page filtering

Tests

• All changes are type/naming/passing-convention fixes with no behavioral change; existing UT/IT coverage suffices to verify no regression

API and Format

• No impact. No public API or storage format changes involved

Documentation

• No documentation update needed; this is a code quality improvement only

Generative AI tooling

No

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Parquet reading internals to improve API efficiency/clarity and adjusts reader behavior documentation.

Changes:

• Renamed an inline ctor-argument comment related to row-group matching/filtering.
• Updated ExecuteSkipReadPattern to take a shared_ptr by const reference.
• Minor internal adjustments in FileReaderWrapper (move memory pool; type tweak) and added an operational TODO about prebuffering.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/paimon/format/parquet/parquet_file_batch_reader.cpp	Adjusts boolean argument annotation when constructing target row groups.
src/paimon/format/parquet/page_filtered_row_group_reader.h	Changes ExecuteSkipReadPattern signature to take shared_ptr by const ref.
src/paimon/format/parquet/page_filtered_row_group_reader.cpp	Keeps implementation signature in sync with header change.
src/paimon/format/parquet/file_reader_wrapper.cpp	Moves memory pool into member, refines row-group id type, and documents prebuffering OOM/IO waste risk.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.