Skip to content

fix(cli): validate UModel YAML files - #94

Open
Chloride233 wants to merge 1 commit into
alibaba:mainfrom
Chloride233:fix/cli-validate-yaml
Open

fix(cli): validate UModel YAML files#94
Chloride233 wants to merge 1 commit into
alibaba:mainfrom
Chloride233:fix/cli-validate-yaml

Conversation

@Chloride233

Copy link
Copy Markdown
Contributor

Summary

This closes a small gap in the local authoring loop: the CLI docs point umctl umodel validate at a quickstart UModel YAML file, but the command only wrapped JSON before calling the validate API.

Now umctl umodel validate can accept one schema-style UModel YAML file and send the same elements payload the API already expects.

Scope

  • Reuses the UModel payload normalizer from import parsing.
  • Keeps umodel put JSON-only.
  • No REST API, MCP, SDK, schema, or Web UI changes.

Tests

  • go test ./cmd/umctl/cmd -run 'TestUModelValidateAcceptsSchemaStyleYAMLFile|TestCLICommandsRouteToCorrectEndpoints' -count=1
  • go test ./internal/umodel/payload -count=1
  • go test ./internal/bootstrap ./internal/sampledata -run 'QuickStart|quickstart|Sample|Localization' -count=1
  • git diff --check

@qiansheng91 qiansheng91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Reviewed PR #94: fix(cli): validate UModel YAML files

The changes appear reasonable. No critical issues found in the diff.


Automated review by github-manager-bot

@qiansheng91

Copy link
Copy Markdown
Collaborator

Issue Evaluation

Category: bug | Status: Needs Verification

Thank you for reporting this issue. The reported behavior is being reviewed against the current codebase.

Next Steps:

  • This issue has been flagged for code-level verification
  • If confirmed, an automated fix proposal may be generated
  • You can reply with additional context, reproduction steps, or logs to help speed up the analysis

Automated evaluation by github-manager-bot

@qiansheng91 qiansheng91 added the bug Something isn't working label Jul 25, 2026
@qiansheng91

Copy link
Copy Markdown
Collaborator

Issue Evaluation

Category: bug | Status: Under Review

Thank you for reporting this issue. It has been classified as a potential bug and is being reviewed against the current codebase.

A deeper verification will be performed. If confirmed as a valid bug, an automated fix proposal may be generated.


Automated evaluation by github-manager

@qiansheng91

Copy link
Copy Markdown
Collaborator

Issue Evaluation

Category: bug | Status: Needs Info

Thank you for reporting this issue. To proceed with verification, please provide:

  • Version/tag where this occurs
  • Steps to reproduce
  • Expected vs actual behavior
  • Relevant logs or stack traces

Automated evaluation by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants