Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for algolia-experiences-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for algolia-experiences-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dhayab
reviewed
Feb 24, 2026
Comment on lines
+246
to
+252
| label, | ||
| ...(start !== undefined && start !== '' | ||
| ? { start: Number(start) } | ||
| : {}), | ||
| ...(end !== undefined && end !== '' | ||
| ? { end: Number(end) } | ||
| : {}), |
Member
There was a problem hiding this comment.
Should the label (and the numbers?) be sanitized?
Member
Author
There was a problem hiding this comment.
Do you mean sanitized as in, have the values completely removed when the 3 inputs are empty? If yes, that's already handled based on the component type.
Member
There was a problem hiding this comment.
In addition, we might want to sanitize them to prevent unwanted behavior when rendering them in the website (thinking this applies to sortby / hitsperpage as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ais.numericMenuwidget in the runtime withtransformParamsthat converts stringstart/endvalues from toolbar inputs to numbersattribute,items(label + min/max bounds), andcssClassesfields