Chore(deps): Bump pynacl from 1.5 to 1.6.0#245
Conversation
|
Failed to retrieve llama text: Invalid URL '/completion': No scheme supplied. Perhaps you meant https:///completion? |
Bumps [pynacl](https://github.com/pyca/pynacl) from 1.5 to 1.6.0. - [Changelog](https://github.com/pyca/pynacl/blob/main/CHANGELOG.rst) - [Commits](pyca/pynacl@1.5.0...1.6.0) --- updated-dependencies: - dependency-name: pynacl dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ec03114 to
a29cfeb
Compare
foxpatch-aleph
left a comment
There was a problem hiding this comment.
The PR bumps pynacl from 1.5 to 1.6.1, but the diff shows a version mismatch: the PR title and description claim to upgrade to 1.6.0, while the actual change pins to 1.6.1. Additionally, the existing comment '# Needed now as default with _load_account changement' is stale and unclear — if pynacl still needs to be pinned to an exact version (rather than using a range like >=1.5), that rationale should be documented. The upgrade itself is low-risk and beneficial (libsodium 1.0.20, Python 3.14 support), but the version discrepancy between the PR description and the actual change needs clarification.
pyproject.toml (line 45): The PR description says this bumps pynacl to 1.6.0, but the diff pins to pynacl==1.6.1. These should match. Please clarify which version is intended and ensure the PR title/description is consistent with the actual change.
pyproject.toml (line 45): The trailing comment '# Needed now as default with _load_account changement' is stale and vague. If an exact pin is still required (rather than >=1.5,<2), the comment should explain why (e.g. a known API break at a specific version). If the pin is no longer necessary, consider relaxing it to a range.
foxpatch-aleph
left a comment
There was a problem hiding this comment.
The PR title and description claim to bump pynacl from 1.5 to 1.6.0, but the actual diff pins the version to 1.6.1, not 1.6.0. This is a mismatch between the stated intent and the actual change. Additionally, the pinned version constraint (==) is overly strict for a dependency bump — it prevents users from receiving patch updates and may cause conflicts with other packages. The comment about '_load_account changement' that motivated the original strict pin should be re-evaluated to determine if it still applies and whether a range specifier (e.g. >=1.6,<2) would be more appropriate.
pyproject.toml (line 45): Version mismatch: the PR description states it bumps pynacl to 1.6.0, but the diff pins to ==1.6.1. These should match. Dependabot generated this PR for 1.6.0, so either the version here is wrong, or the PR description is stale. Please align the two.
pyproject.toml (line 45): The strict == pin is very restrictive. The original comment says it was 'Needed now as default with _load_account changement' — if that constraint no longer applies (or if pynacl 1.6.x has stabilised the relevant API), consider relaxing to >=1.6,<2 to allow future patch/minor updates without manual PRs.
Bumps pynacl from 1.5 to 1.6.0.
Changelog
Sourced from pynacl's changelog.
... (truncated)
Commits
3209bf1release 1.6.0 (#891)15bc45dupgrade to libsodium 1.0.20-stable 2025-08-27 build (#890)ac958e0fix doc mistake (#892)593fb5eupdate changelog and drop support for python 3.7 (#888)7bc6126fix var casing in wheel builder (#889)59f9595Support Python 3.14 and 3.14t (#880)2860f98Bump actions/setup-python from 5 to 6 (#887)b712d60Update CI for the new staticnode location (#885)1780489Bump actions/checkout from 4.2.2 to 4.3.0 (#883)e03ffeeBump actions/download-artifact from 4.3.0 to 5.0.0 (#882)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)