Chore(deps): Bump aleph-pytezos from 0.1.1 to 3.13.4#171
Chore(deps): Bump aleph-pytezos from 0.1.1 to 3.13.4#171dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
Failed to retrieve llama text: Invalid URL '/completion': No scheme supplied. Perhaps you meant https:///completion? |
|
See #148 to combine those 2 PRs |
Bumps [aleph-pytezos](https://github.com/pyscaffold/pyscaffold) from 0.1.1 to 3.13.4. - [Release notes](https://github.com/pyscaffold/pyscaffold/releases) - [Changelog](https://github.com/pyscaffold/pyscaffold/blob/master/CHANGELOG.rst) - [Commits](https://github.com/pyscaffold/pyscaffold/commits) --- updated-dependencies: - dependency-name: aleph-pytezos dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
aab61ad to
bb2a33c
Compare
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This is a single-line dependency pin bump of aleph-pytezos from 0.1.1 to 3.13.4 — a massive major-version jump. The code change itself is minimal and correct. However, the PR description's release notes and changelog link to pyscaffold/pyscaffold, not the actual aleph-pytezos package, which means there are no meaningful release notes to evaluate the impact of this bump. The jump from 0.1.1 to 3.13.4 likely reflects that aleph-pytezos versioning tracks upstream pytezos releases, but this should be confirmed before merging. The API surface used in tezos.py (Key.from_secret_exponent, Key.from_encoded_key, .sign(), .verify(), .public_key_hash(), .public_key()) appears unchanged, but without a verified changelog the API compatibility cannot be fully guaranteed.
pyproject.toml (line 83): The PR description's release notes and changelog point to pyscaffold/pyscaffold (not aleph-pytezos), so there is no reliable changelog available for this bump. Before merging, manually verify on PyPI or the aleph-im/aleph-pytezos GitHub that version 3.13.4 is the intended release and that the aleph_pytezos.crypto.key.Key API used in src/aleph/sdk/chains/tezos.py (specifically from_secret_exponent, from_encoded_key, sign, verify, public_key_hash, public_key) is unchanged. The version jump from 0.1.1 to 3.13.4 suggests the package version now tracks upstream pytezos, which would be a significant packaging change worth confirming.
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This is a single-line dependency bump of aleph-pytezos from 0.1.1 to 3.13.4 — a very large version jump (0.x → 3.x). The package is used in src/aleph/sdk/chains/tezos.py via aleph_pytezos.crypto.key.Key with methods from_secret_exponent, from_encoded_key, sign, verify, public_key, and public_key_hash. The change itself is mechanically correct, but the magnitude of the version bump warrants explicit verification that the API surface used by tezos.py is unchanged. Notably, the PR description links to pyscaffold's changelog — dependabot appears to have confused the package URL — so the release notes shown are entirely irrelevant to aleph-pytezos. No bugs or security issues are apparent in the diff itself.
pyproject.toml (line 83): The jump from 0.1.1 to 3.13.4 is very large (major version change). The PR description's changelog and release notes are for pyscaffold, not aleph-pytezos — dependabot linked the wrong repository. Before merging, manually confirm that the aleph_pytezos.crypto.key.Key API used in tezos.py (specifically from_secret_exponent, from_encoded_key, sign, verify, public_key, public_key_hash) is compatible with 3.13.4. The Tezos unit tests in tests/unit/test_chain_tezos.py should be run against the new version to catch any breakage.
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This is a large major version bump (0.1.1 → 3.13.4) of aleph-pytezos, which is likely the aleph.im fork of pytezos tracking upstream versioning. The single-line change in pyproject.toml is correct, and existing tests cover the relevant API surface (Key.from_secret_exponent, key.sign, key.public_key_hash, key.public_key, Key.from_encoded_key, key.verify). However, two things warrant attention before merging: the PR metadata links to pyscaffold/pyscaffold instead of aleph-pytezos, making it impossible to assess what changed in the package; and a major-version jump of this magnitude should be verified for API compatibility either via CI or manual inspection.
pyproject.toml (line 84): The dependabot PR description links to pyscaffold/pyscaffold for aleph-pytezos's release notes and changelog — the wrong repository entirely. This means the package's PyPI metadata has incorrect source links, and there is no actual changelog available in this PR to assess what changed between 0.1.1 and 3.13.4. Before merging, please manually verify the aleph-pytezos 3.13.4 package on PyPI (or its actual source repo) to confirm the API surface used in src/aleph/sdk/chains/tezos.py is unchanged: specifically Key.from_secret_exponent, Key.from_encoded_key, key.sign() return type (currently assumed to be a value on which .encode() is called), key.verify(), key.public_key(), and key.public_key_hash().
pyproject.toml (line 84): The version is pinned exactly (==3.13.4), which is consistent with the previous pin. This is acceptable for optional dependency groups but worth noting that any future patch releases of aleph-pytezos will require another PR like this one.
Bumps aleph-pytezos from 0.1.1 to 3.13.4.
Release notes
Sourced from aleph-pytezos's releases.
... (truncated)
Changelog
Sourced from aleph-pytezos's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)