Fix performance for filter today events function#456
Open
hoangqwe159 wants to merge 2 commits intoaldabil21:masterfrom
Open
Fix performance for filter today events function#456hoangqwe159 wants to merge 2 commits intoaldabil21:masterfrom
hoangqwe159 wants to merge 2 commits intoaldabil21:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Performance Regression in Recurring Event Timezone Conversion
Problen and fix demo
https://drive.google.com/file/d/1aLZ7Pyqvd9ilqmWYt0st8t-9bQjmfUtO/view?usp=sharing
Summary
This PR fixes a significant performance regression introduced in the recent timezone handling refactor for recurring events. The previous implementation was performing timezone conversions on every recurrence instance, causing O(n × r) complexity instead of O(n), where r = number of recurrences per event.
Problem
The recent changes to
getRecurrencesForDateandfilterTodayEventsintroduced several performance issues:Example Impact
Intl.DateTimeFormatcallsIntl.DateTimeFormatcallChanges
getRecurrencesForDateFunctiontimeZoneparameter from function signaturebetween(today, addDays(today, 1), true)convertRRuleDateToDateutility for proper RRule date handlingfilterTodayEventsFunctiongetRecurrencesForDate(events[i], today, timeZone)to:Testing
Performance Metrics
Breaking Changes
None - this is a performance optimization that maintains the same external behavior.