Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
jakehobbs
requested review from
0xfourzerofour,
Richard-Dang,
SahilAujla,
avarobinson,
blakecduncan,
clinder777,
dancoombs,
florrdv,
niveda-krish,
pavelm and
thebrianchen
as code owners
jakehobbs
changed the title
jakehobbs
commented
Mar 27, 2026
| "dependencies": { | ||
| "@alchemy/common": "workspace:*", | ||
| "@alchemy/wallet-api-types": "0.1.0-alpha.26", | ||
| "@alchemy/wallet-api-types": "link:/Users/jacob.hobbs/dev/alchemyplatform/wallet-server/types", |
Collaborator
Author
There was a problem hiding this comment.
need to update this once a new `@alchemy/wallet-api-types`` pkg is published.
Collaborator
Author
There was a problem hiding this comment.
also pls check that all the type errors are gone after that
jakehobbs
commented
Mar 27, 2026
| import { createSmartWalletClient } from "./src/client.js"; | ||
| import { alchemyWalletTransport } from "./src/transport.js"; | ||
|
|
||
| // TODO(jh): remove this after done testing manually. |
Collaborator
Author
There was a problem hiding this comment.
remove this before merging
jakehobbs
commented
Mar 27, 2026
Collaborator
Author
There was a problem hiding this comment.
look into why such large diff... i think we might be accidentally running prettier on this somewhere
Co-Authored-By: Claude <noreply@anthropic.com>
niveda-krish
approved these changes
Mar 27, 2026
jakehobbs
commented
Mar 27, 2026
| * @example | ||
| * ```ts | ||
| * const result = await client.undelegateAccount(); | ||
| * const status = await client.waitForCallsStatus({ id: result.id }); |
Collaborator
Author
There was a problem hiding this comment.
should we consider just waiting in undelegateAccount?
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily introduces the
undelegateAccountfunctionality into thewallet-apispackage, allowing users to remove delegation from an account. It also updates dependencies and adds tests for the new feature.Detailed summary
@alchemy/wallet-api-typesdependency to a local link.undelegateAccounttype and function inundelegateAccount.ts.undelegateAccountinindex.ts.undelegateAccountinSmartWalletActions.undelegateAccountinclient.e2e.test.ts.signPreparedCalls.tsto handle authorization for undelegation.